[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

> I think I prefer to set it to ON by default and then have people specify it if they want to change it to OFF.

I fear that this would silently regress the performance of release builds for some people.

> - We can flip it to ON if you don't specify CMAKE_BUILD_TYPE and OFF if you pass Release and ON when passing debug. But this seems a bit ... convoluted? Is that really what end users expect?

Actually I think that's exactly how it works today :-)

I see your point about the logic getting convoluted, but I don't think it'd be too bad, especially since we're printing a message about it anyway. It could be "No build type selected, default to Release with asserts enabled".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153