[PATCH] D124111: [AMDGPU]: Fix failing assertion in SIMachineScheduler

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus marked 2 inline comments as done.
jsilvanus added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:1128-1129
+      // dependencies is a non-export, in which case we skip export grouping.
+      for (SDep const &SuccDep : SU.Succs) {
+        SUnit const *SuccSU = SuccDep.getSUnit();
+        if (SuccDep.isWeak() || SuccSU->NodeNum >= DAG->SUnits.size()) {
----------------
arsenm wrote:
> east const?
Sorry, fixed. 10 years of east const are hard-wired into my brain I assume.
Good to know that clang-format does not pick this one up.


================
Comment at: llvm/test/CodeGen/AMDGPU/si-scheduler-exports.ll:27
+
+attributes #0 = { "target-features"=",+si-scheduler" }
----------------
arsenm wrote:
> This is redundant with the -mattr on the run line
Thanks, fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124111/new/

https://reviews.llvm.org/D124111