[PATCH] D123777: [CMake] Check for problematic MSVC + /arch:AVX configuration

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 21:54:02 PDT 2022


phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: llvm/cmake/modules/CheckProblematicConfigurations.cmake:4
+
+macro(LOG_PROBLEMATIC MESSAGE)
+  if(LLVM_ALLOW_PROBLEMATIC_CONFIGURATIONS)
----------------
We usually use `lower_case` for the names of functions and macros.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123777/new/

https://reviews.llvm.org/D123777



More information about the llvm-commits mailing list