[PATCH] D124077: [mlir][PDLL] Add document link and hover support to mlir-pdll-lsp-server

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: mlir/lib/Tools/mlir-pdll-lsp-server/PDLLServer.cpp:502
+    llvm::raw_string_ostream hoverOS(hover.contents.value);
+    hoverOS << "`" << llvm::sys::path::filename(include.uri.file())
+            << "`\n***\n"
----------------
OOC does this enable linkage? Or would one need to write this in markdown formatting?


================
Comment at: mlir/test/mlir-pdll-lsp-server/include/included.td:1
+
+include "mlir/IR/OpBase.td"
----------------
Are the empty new lines at top on purpose? File heading missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124077/new/

https://reviews.llvm.org/D124077