[PATCH] D124111: [AMDGPU]: Fix failing assertion in SIMachineScheduler
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 20 13:39:41 PDT 2022
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nits
================
Comment at: llvm/lib/Target/AMDGPU/SIMachineScheduler.cpp:1128-1129
+ // dependencies is a non-export, in which case we skip export grouping.
+ for (SDep const &SuccDep : SU.Succs) {
+ SUnit const *SuccSU = SuccDep.getSUnit();
+ if (SuccDep.isWeak() || SuccSU->NodeNum >= DAG->SUnits.size()) {
----------------
east const?
================
Comment at: llvm/test/CodeGen/AMDGPU/si-scheduler-exports.ll:27
+
+attributes #0 = { "target-features"=",+si-scheduler" }
----------------
This is redundant with the -mattr on the run line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124111/new/
https://reviews.llvm.org/D124111
More information about the llvm-commits
mailing list