[PATCH] D124115: [Attributes] Update Attribute::get API to consider zero value for int attributes

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

I would prefer to split this into two overloads, one without the uint64_t argument creating an enum attribute and one with creating always an int attribute, and fix up any problematic uses accordingly. The current approach leaves behind a footgun if we start actually using zero values for int attributes (something that we are careful not to do currently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124115/new/

https://reviews.llvm.org/D124115