[PATCH] D94015: [LoopIdiom] Replace cttz loop by call to cttz intrinsic.

Dawid Jurczak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 12:27:07 PDT 2022


yurai007 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1975
+
+  if (LoopHeader->sizeWithoutDebug() < IdiomCanonicalSize)
+    return false;
----------------
Since it's running on all targets I wonder whether checking size is enough. For example - in case of CTLZ transformation profitability is checked by additional query to TTI. More context: https://reviews.llvm.org/D32605#752717


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94015/new/

https://reviews.llvm.org/D94015



More information about the llvm-commits mailing list