[PATCH] D121727: [NVPTX] Integrate ptxas to LIT tests

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 12:24:57 PDT 2022


tra added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/bug41651.ll:2
+; RUN: llc -filetype=asm -o - %s -o %t.ptx
+; RUN: %if ptxas %{ %ptxas-verify %t.ptx %}
+; RUN: FileCheck %s --input-file %t.ptx
----------------
Here and everywhere -- I'd run conditional ptxas testing as the **last** step. 
We should make sure that the actual tests have succeeded, first. No point running ptxas on the output that we already know is wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121727/new/

https://reviews.llvm.org/D121727



More information about the llvm-commits mailing list