[PATCH] D124106: [lld/mac] Warn that writing zippered outputs isn't implemented

Wed Apr 20 10:33:13 PDT 2022

thakis planned changes to this revision.
thakis added a comment.

In D124106#3462436 <https://reviews.llvm.org/D124106#3462436>, @steven_wu wrote:

> Maybe it is easier if you only warn if multiple different platforms are specified? You can preserve the last one wins for the same platform.
> Or even more specifically, the only supported configuration is `macOS` + `macCatalyst` and you can only toss out a warning if this configuration is used.

I think that doesn't change all that much: There are things like `%lld -dylib -platform_version ios ...`, so some of the cases do mix platforms. I suppose I could move those to `%no-arg-lld` and keep the current "`%lld` means mac" semantics. I'll do that for this change this it makes the change smaller. (I vaguely like if `%lld` was just lld, there was no `%no-arg-lld`, and the current thing was called `%lld-mac`, but after your suggestion it's really independent of this patch here, and I'm not sure I like it enough to warrant changing all the tests.)

Also, you're right, I have to handle multiple -platform_version flags for the same platform better. Currently this warns on 2 `-platform_version macos` flags, which is incorrect.

Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124106/new/

https://reviews.llvm.org/D124106