[PATCH] D124092: CodeGen: Remove MaxBytesForAlignment from MachineBasicBlock

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 07:39:57 PDT 2022


arsenm created this revision.
arsenm added reviewers: NickGuy, dmgreen, gchatelet, SjoerdMeijer, courbet, Carrot.
Herald added a subscriber: hiraditya.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

This was an overcomplicated way of tracking a constant used in the
AsmPrinter. This was not serialized in MIR. None of the in tree code
was changing this dynamically based on individual blocks. It was
always set to a subtarget defined constant.

      

This should probably be moved out of TargetLowering and into
MCAsmInfo. The only place I think this should change codegen is
BranchRelaxation which didn't account for potentially ignored
alignment in the first place.


https://reviews.llvm.org/D124092

Files:
  llvm/include/llvm/CodeGen/MachineBasicBlock.h
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/BranchRelaxation.cpp
  llvm/lib/CodeGen/MachineBlockPlacement.cpp
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/tools/llvm-reduce/ReducerWorkItem.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124092.423904.patch
Type: text/x-patch
Size: 7968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220420/f54a86b9/attachment.bin>


More information about the llvm-commits mailing list