[PATCH] D122635: [RISCV] Filter out instructions which contain unsafe things when outlining

Wed Apr 20 05:15:05 PDT 2022

pcwang-thead added a comment.

In D122635#3461473 <https://reviews.llvm.org/D122635#3461473>, @luismarques wrote:

> Is this patch still relevant?

As what I said before:

> I have written several MIR tests but found that we don't need to filter out these cases.
>
> - For MO.isCFIIndex(), we have handled CFIs before, so there is no need to do it again.
> - For MO.isFI(), because Machine Outliner runs after Prologue/Epilogue Insertion & Frame Finalization, so there is no FrameIndex any more(If I understand correctly).
> - For MO.isTargetIndex(), RISCV has no implemented target index, so it is unnecessary. ARM/AArch64/X86 have no target index too, which is weird.
>
> I don't know why other targets exclude these operand types, but I may abandon this patch if it is actually meaningless.

I think this patch makes no difference to outlining, but it is no harm to land since other targets do the same things.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122635/new/

https://reviews.llvm.org/D122635