[PATCH] D124068: [NewGVN][LoadCoercion] Add tests for future commit.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 20 01:45:30 PDT 2022


foad added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/load_coercion_between_store_and_load.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -gvn < %s | FileCheck %s -check-prefix=GVN-CHECK
+
----------------
kmitropoulou wrote:
> foad wrote:
> > Should be testing `-newgvn` instead of gvn?
> I just wanted to prove that we do the same thing as GVN. None of these tests are optimized with NewGVN. If we prefer to see the diff, then I can change it :)
I see. Then maybe use two RUN lines:
```
; RUN: opt -S -gvn < %s | FileCheck %s -check-prefixes=GVN,OLDGVN
; RUN: opt -S -newgvn < %s | FileCheck %s -check-prefixes=GVN,NEWGVN
```
(as suggested offline).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124068/new/

https://reviews.llvm.org/D124068



More information about the llvm-commits mailing list