[PATCH] D124063: [LegacyPM] Rename and deprecate populateModulePassManager

Wed Apr 20 00:47:37 PDT 2022

nikic added a comment.

In D124063#3461171 <https://reviews.llvm.org/D124063#3461171>, @MaskRay wrote:

> In D124063#3461133 <https://reviews.llvm.org/D124063#3461133>, @nikic wrote:
>
>> Please do not change names in the FFI API at least. It's okay to drop it entirely, but renaming is unnecessarily hostile for FFI APIs.
>
> Why?

Users of the FFI interface generally target multiple LLVM versions, so they need to introduce checks to use one or the other API -- if lucky only compile-time checks, if not lucky it requires switching the code to use dlsym. This may be unavoidable if an API is removed, but it's an unnecessary complication for a rename.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124063/new/

https://reviews.llvm.org/D124063