[PATCH] D123142: [llvm-ar] Fix thin archive being wrongly converted to a full archive

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/regular-to-thin-archive.test:28
+# RUN: llvm-ar -t --thin %t/archive.a
+
+# RUN: FileCheck --check-prefixes=REGULAR --input-file=%t/archive.a %s
----------------
Nit: I'd delete this blank line, since the line before is strongly tied to the lines immediately after.


================
Comment at: llvm/test/tools/llvm-ar/thin-to-regular-archive.test:34
+# RUN: llvm-ar -qL %tregular2.a.a %tthin.a
+# RUN: FileCheck --check-prefixes=REGULAR --input-file=%tfull2.a %s
+
----------------
This test is failing the premerge checks, presumably because of the out-of-date `%tfull2.a` name.


================
Comment at: llvm/test/tools/llvm-ar/thin-to-regular-archive.test:36
+
+## Test that thin archives do not convert to a regular archive with 'L' and no use of '--thin'.
+# RUN: llvm-ar -qL %tthin.a %tregular2.a.a
----------------
Nit: consistency between singular versus plural.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123142/new/

https://reviews.llvm.org/D123142