[PATCH] D123799: [RISCV] Mark FSIN and other math functions as Expand for scalable vectors.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 23:57:21 PDT 2022


craig.topper added a comment.

In D123799#3461104 <https://reviews.llvm.org/D123799#3461104>, @frasercrmck wrote:

> I agree they should probably be invalid, conceptually, but in reality I don't like that we have users of cost models crash when encountering invalid costs, with the rationale that the IR shouldn't contain anything with an invalid cost. I don't see how those two models are compatible.

Invalid cost is a recent concept. Did the project fail to update some code to comprehend the possibility of invalid costs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123799/new/

https://reviews.llvm.org/D123799



More information about the llvm-commits mailing list