[PATCH] D123198: [LibCalls] Add argument extension attributes to more functions.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 22:42:39 PDT 2022


MaskRay reopened this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Transforms/Utils/BuildLibCalls.h:31
   /// Returns true if any attributes were set and false otherwise.
-  bool inferLibFuncAttributes(Function &F, const TargetLibraryInfo &TLI);
-  bool inferLibFuncAttributes(Module *M, StringRef Name, const TargetLibraryInfo &TLI);
+  bool inferNonMandatoryLibFuncAttrs(Module *M, StringRef Name,
+                                     const TargetLibraryInfo &TLI);
----------------
While updating function signatures, it may be worth checking whether M is non-null and may use Module &M


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123198/new/

https://reviews.llvm.org/D123198



More information about the llvm-commits mailing list