[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/utils/lit/lit/formats/googletest.py:114
+            'GTEST_COLOR': 'no',
+            'GTEST_SHUFFLE': '1' if use_shuffle else '0',
+            'GTEST_TOTAL_SHARDS': total_shards,
----------------
Why it uses env variables when gtest has has command line flags for that? Seems flags are more portable and easier to work with emulators.


================
Comment at: llvm/utils/lit/lit/formats/googletest.py:131
+            shard_envs = '\n'.join([k + '=' + v for k, v in shard_env.items()])
+            return f"Script(shard):\n--\n%s\n%s\n--\n" % (shard_envs, ' '.join(cmd))
+
----------------
'Script' used to be convenient oneliner which can be copy/pasted into shell for debugging, now it's not.
also GTEST_OUTPUT and GTEST_COLOR are not needed for that purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251