[PATCH] D123932: MachineModuleInfo: Move HasSplitStack handling to AsmPrinter

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 16:56:22 PDT 2022


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:219
+  /// True if the module contains no-split-stack functions. This is used to
+  /// emit .note.GNU-no-split-stack section when it also contains split-stack
+  /// functions.
----------------
I think this is missing a negative, maybe it can be "when it also contains functions without a split stack prologue".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123932/new/

https://reviews.llvm.org/D123932



More information about the llvm-commits mailing list