[PATCH] D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID

[Matthew Voss via Phabricator via llvm-commits]

ormris added a comment.

> I think this will introduce a correctness issue as it will become possible for two modules that can be linked together to have the same unique module ID.

Our goal with this change was to reduce the hash collisions we were finding in internal testing of the unified LTO pipeline. The previous method wasn't quite broad enough for our internal tests. While we've certainly constructed test cases that cause a collision when using the changes in this patch, we've never seen a collision when working with real code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123969/new/

https://reviews.llvm.org/D123969