[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 19 14:14:04 PDT 2022
tejohnson added a comment.
lgtm if you are waiting for a re-review. As noted in my previous comment, you have added a little bit of unnecessary checking at the lower end with your new clamp function, since it is an unsigned value and can never go below 0. But it isn't a big deal if you prefer to keep that in to make it easier to transition to std::clamp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115907/new/
https://reviews.llvm.org/D115907
More information about the llvm-commits
mailing list