[PATCH] D123928: [NVPTX][tests] Do not run the tests which are not supported by nvptx

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

Few more nits. 
LGTM otherwise.



================
Comment at: llvm/test/CodeGen/Generic/2007-12-17-InvokeAsm.ll:4
+; NVPTX does not support memory address operands
+; UNSUPPORTED: nvptx
+
----------------
i-chebykin wrote:
> tra wrote:
> > This should probably be "REQUIRE: x86" instead, as it uses inline assembly with x86-specific constraints.
> REQUIRES is matched against features only, 
> so we need to use `REQUIRES: x86{{.*}}` or maybe `REQUIRES: {{.*}}x86{{.*}}`
> Is it good?
> 
No idea. Considering that nobody else complains about it, it's OK to just disable it for nvptx for now.


================
Comment at: llvm/test/CodeGen/Generic/APIntParam.ll:3
+
+; UNSUPPORTED: nvptx
+
----------------
"; NVPTX does not support arbitrary integer types and has acceptable subset tested in NVPTX/APIntParam.ll"


================
Comment at: llvm/test/CodeGen/Generic/APIntSextParam.ll:3
+
+; UNSUPPORTED: nvptx
+
----------------
ditto.


================
Comment at: llvm/test/CodeGen/Generic/APIntZextParam.ll:3
+
+; UNSUPPORTED: nvptx
+
----------------
ditto.


================
Comment at: llvm/test/CodeGen/Generic/empty-load-store.ll:4
 
+; UNSUPPORTED: nvptx
+
----------------
i-chebykin wrote:
> tra wrote:
> > What happens in this case? AFAICT, llc appears to work with this IR: https://godbolt.org/z/n1eK193br
> > 
> llc from assertions trunk crashed
> my build with -DLLVM_ENABLE_ASSERTIONS=On crashed too
Please add a note here and elsewhere. "Triggers a crash on assertion as NVPTX does not support 0-sized arrays.".
This particular case may actually be a bug.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123928/new/

https://reviews.llvm.org/D123928