[PATCH] D123225: [ThreadPool] add ability to group tasks into separate groups
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 19 13:01:10 PDT 2022
MaskRay added inline comments.
================
Comment at: llvm/include/llvm/Support/ThreadPool.h:117
+ typedef std::deque<std::pair<std::function<void()>, ThreadPoolTaskGroup *>>
+ TaskQueue;
+
----------------
aganea wrote:
> This is a bit confusing, we already have a `llvm::TaskQueue`, can we change this to something else? Just `Queue` maybe?
We can even omit the type alias. I think this is only used once for the member variable.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123225/new/
https://reviews.llvm.org/D123225
More information about the llvm-commits
mailing list