[PATCH] D121940: [SLP] Support internal users of splat loads

Vasileios Porpodas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 10:48:24 PDT 2022


vporpo added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:1169
     /// Also, checks if \p V1 and \p V2 are compatible with instructions in \p
     /// MainAltOps.
+    int getShallowScore(Value *V1, Value *V2, Instruction *U1, Instruction *U2,
----------------
vdmitrie wrote:
> New arguments are not  described.
Good point. U1 and U2 correspond to the users of V1 and V2 as we are walking up the operands. Let me fix this in a new patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121940/new/

https://reviews.llvm.org/D121940



More information about the llvm-commits mailing list