[PATCH] D123386: [AArch64] Add lane moves to PerfectShuffle tables

Tue Apr 19 08:16:22 PDT 2022

dmgreen added inline comments.

================
Comment at: llvm/utils/PerfectShuffle/PerfectShuffle.cpp:317
+        // lane insert to fixup the result.
+        unsigned MinVal = i;
+        unsigned MinCost = ShufTab[i].Cost;
----------------
nemanjai wrote:
> This is unused and is causing build breaks with `-Werror`:
> https://lab.llvm.org/buildbot/#/builders/57/builds/17025
Oh yeah, so it does. I will fix that now. Sorry for not spotting that earlier, this file is really a utility that does need to be part of the build as far as I understand. It's really just a stand-alone cpp file.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123386/new/

https://reviews.llvm.org/D123386