[PATCH] D123864: [LoopPeel][NFC] Exit early if there is no room for peeling
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 19 03:50:40 PDT 2022
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:389
+ // Skip peeling if there is no room for it.
+ if (2 * LoopSize > Threshold || !UnrollPeelMaxCount)
----------------
I think it's not quite clear what 'no room' means here. the condition here checks 2 things: 1) the size after peeling one iteration exceeds the threshold and 2) that there is at least on iteration to peel.
It would be good to include both in the comment here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123864/new/
https://reviews.llvm.org/D123864
More information about the llvm-commits
mailing list