[PATCH] D123821: [llvm-objcopy][NFC] refactor restoreStatOnFile out of llvm-objcopy.

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/lib/Support/FileUtilities.cpp:341
+
+Error FilePermissionsCarrier::apply(
+    StringRef OutputFilename, bool CopyDates,
----------------
jhenderson wrote:
> Why do you need this extra layer here and not just do the check in the other `apply` function?
I thought about adding other variants of interface methods. Like 

apply(StringRef OutFileName);

In this case there would be several interface methods with different arguments and single internal method used to implementation.

but finally decided to have single universal interface method. So we can remove extra layer in this version of the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123821/new/

https://reviews.llvm.org/D123821