[PATCH] D122287: [XCOFF] support writing sections, relocations and symbols for XCOFF64.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 00:49:37 PDT 2022


jhenderson added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/basic-toc-data-def.ll:3-7
+; RUN:   -verify-machineinstrs < %s 2>&1 | FileCheck %s --check-prefix=OBJ
+
+; RUN: llc -mtriple powerpc64-ibm-aix-xcoff -verify-machineinstrs < %s | FileCheck %s
+; RUN: not --crash llc -filetype=obj -mtriple powerpc64-ibm-aix-xcoff  \
+; RUN:   -verify-machineinstrs < %s 2>&1 | FileCheck %s --check-prefix=OBJ
----------------
FWIW, I'd actually keep the old style here, as it makes it clear which commands the options apply to, whilst still indicating FileCheck is a continuation. Same applies in similar cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122287/new/

https://reviews.llvm.org/D122287



More information about the llvm-commits mailing list