[PATCH] D119787: [ELF][PPC64] Fix assertion failure for branches to hidden undefined weak for -no-pie

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 20:24:25 PDT 2022


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/PPC64.cpp:1386
+  // isUndefined() here. A undefined non-weak symbol has been errored.
+  if (s.isUndefined())
     return false;
----------------
Miss_Grape wrote:
> Why externally referenced symbols, this is not the type of undefined symbols here?I would like to know what kind of scenario is being dealt with here
I do not understand the question. "externally referenced symbol" is not a linker term. The symbol type is irrelevant. The condition has been explained in the updated comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119787/new/

https://reviews.llvm.org/D119787



More information about the llvm-commits mailing list