[PATCH] D122963: [X86] Extend the integer parameter if the function isn't local linked

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added a comment.

> I don't think we've reached agreement that this is a bug. I am concerned that removing these extension assert nodes will result in performance regressions.

The performance concern looks reasonable. We need collect performance data to prove there is no performance regression for typical benchmarks.

> I think in cases where we disagree and are blocking each other, that's when we need to resort to flags to make forward progress. What do you think about adding a cl::opt for this feature? At the very least, this will allow folks to do their own performance testing, even if we ultimately default to GCC's behavior. I see the OpenVMS folks <https://discourse.llvm.org/t/always-extend-the-integer-parameters-of-callee/61319/9?u=rnk> have a setting for this as well ("assume clean parameters").

Adding cl::opt looks good to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122963/new/

https://reviews.llvm.org/D122963