[PATCH] D123969: [LTO] Use names from more GlobalValue types to generate the ModuleID

[Matthew Voss via Phabricator via llvm-commits]

ormris created this revision.
ormris added reviewers: tejohnson, pcc, mehdi_amini.
Herald added subscribers: steven_wu, hiraditya, inglorion.
Herald added a project: All.
ormris requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In many situations the current version of getUniqueModuleId returns no hash. This causes problems for ThinLTOBitcodeWriter pass, and it will fall back to generating a regular LTO module in these cases. Since it's preferable to generate a ThinLTO module for performance reasons, this patch allows getUniqueModuleId to use more types of GlobalValues when generating the ModuleId hash. This mix has been fairly reliable for us.

This change is part of the Unified LTO RFC: https://discourse.llvm.org/t/rfc-a-unified-lto-bitcode-frontend/61774


https://reviews.llvm.org/D123969

Files:
  llvm/lib/Transforms/Utils/ModuleUtils.cpp
  llvm/test/LTO/Resolution/X86/llvm-used-moduleid.ll
  llvm/test/LTO/Resolution/X86/weak-linkage-moduleid.ll
  llvm/test/LTO/X86/path-moduleid.ll
  llvm/test/Transforms/Util/generate-moduleid.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123969.423496.patch
Type: text/x-patch
Size: 5303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220419/795e388b/attachment.bin>