[PATCH] D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 17:36:31 PDT 2022
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM with nit
================
Comment at: llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp:209-215
+ if (Op.isReg()) {
+ Register Reg = Op.getReg();
+ if (!MAI.hasRegisterAlias(MF, Reg)) {
+ Register NewReg = Register::index2VirtReg(MAI.getNextID());
+ MAI.setRegisterAlias(MF, Reg, NewReg);
+ }
+ }
----------------
Could use another continue and indentation reduction
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116465/new/
https://reviews.llvm.org/D116465
More information about the llvm-commits
mailing list