[PATCH] D60294: [DAGCombiner] [CodeGenPrepare] Split large offsets from base addresses

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.
Herald added subscribers: pcwang-thead, luke957, StephenFan, frasercrmck, kerbowa, sameer.abuasal, steven.zhang, pengfei, s.egerton, Jim, MaskRay, arichardson.
Herald added a project: All.


================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1076
+
+  for (SDNode *Node : N0->uses()) {
+    auto LoadStore = dyn_cast<MemSDNode>(Node);
----------------
Doing some archaelogy.

Should this be checking the uses of the `(add, (add, x, offset1), offset2))` expression? It seems to be checking the uses of `(add x, offset1)`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60294/new/

https://reviews.llvm.org/D60294