[PATCH] D123942: llvm-reduce: Don't delete triple/datalayout
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 15:17:31 PDT 2022
arsenm added a comment.
In D123942#3457398 <https://reviews.llvm.org/D123942#3457398>, @aeubanks wrote:
> we probably have different experiences, but personally I do find reducing the triple/datalayout helpful, a lot of the things I reduce aren't affected by the two. I don't think it's a bad thing that this depends on whether or not the test script passes `-mtriple` or not, llvm-reduce is doing its job and reducing as much as possible
>
> however, I can see why it might be annoying, and re-adding the two lines is more work than deleting them
>
> perhaps a flag to toggle this behavior?
I'm trying to fix needing extra flags that I will need in 100% of cases. As far as things that are manually reducible, deleting the triple/datalayout is as easy as it gets, and about as much work as adding an option flag
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123942/new/
https://reviews.llvm.org/D123942
More information about the llvm-commits
mailing list