[PATCH] D123962: [InstCombine] fold freeze of partial undef/poison vector constants

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D123962#3457622 <https://reviews.llvm.org/D123962#3457622>, @lebedev.ri wrote:

> Given that we are replacing `freeze constant` with `constant`, and selecting the constant based on all the users,
> can we instead go over all the users, and perform replacement for each one separately, always picking the best choice?

Yes, we could use `getBinOpIdentity` or `getSafeVectorConstantForBinop` or something like that. But I think it would be bigger/independent of this change, and I haven't seen a need for it yet. Add a TODO?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123962/new/

https://reviews.llvm.org/D123962