[PATCH] D116952: [ConstantFolding] Respect denormal handling mode attributes when folding instructions

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1342
+    DenormalMode DenormMode = F->getDenormalMode(Ty->getFltSemantics());
+    llvm::DenormalMode::DenormalModeKind Mode =
+        IsOutput ? DenormMode.Output : DenormMode.Input;
----------------
Don't need llvm::


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/constant-fold-fp-denormal.ll:3
+
+target triple = "aarch64--linux-gnu"
+
----------------
Don't need a specific target here


================
Comment at: llvm/test/Transforms/InstCombine/AArch64/constant-fold-fp-denormal.ll:4
+target triple = "aarch64--linux-gnu"
+
+define float @test_float() #0 {
----------------
Would it be helpful to have some constantexpr cases in a global initializer?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116952/new/

https://reviews.llvm.org/D116952