[PATCH] D123284: [ArgPromotion][Attributor] Update min-legal-vector-width when do promotion

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 13:20:47 PDT 2022


jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/ArgumentPromotion/byval-3.ll:25
+
+attributes #0 = { uwtable "min-legal-vector-width"="0" }
----------------
I don't understand this test. Where does the 512 come from and why does it replace the 0 (which from a min perspective is less). Also, this has no byval even though the name of the test is byval-3.ll. Finally, I'd suggest to avoid the undef and UB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123284/new/

https://reviews.llvm.org/D123284



More information about the llvm-commits mailing list