[PATCH] D123933: X86: Remove UsesMSVCFloatingPoint from MachineModuleInfo

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: mstorsjo.
rnk added a comment.

This is sort of reasonable, but I feel like people might disagree so I won't go ahead and stamp it.

I feel like the existing code adheres to the philosophy that the IR will not be available after codegen, and that ISel is responsible for looking at the IR and saving all these analysis results. There's something undesirable about looking back at the IR once we reach the end of assembly emission.

On the other hand, it's also nice to not have all these long-lived predicates stashed in a side table that we then have to serialize through MIR.

I think in the end, we should land this change, but I'd like to see another +1. If people don't like this, maybe we can use X86MachineFunctionInfo.

Lastly, has anyone checked if MSVC emits _fltused on AArch64 / ARM? Maybe it's not as target-specific as it appears. + at mstorsjo


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123933/new/

https://reviews.llvm.org/D123933