[PATCH] D123934: MachineModuleInfo: Remove UsesMorestackAddr

Mon Apr 18 11:57:48 PDT 2022

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:832
+  // Emit __morestack address if needed for indirect calls.
+  if (TT.getArch() == Triple::x86_64 && TM.getCodeModel() == CodeModel::Large) {
+    if (MCSymbol *AddrSymbol = OutContext.lookupSymbol("__morestack_addr")) {
----------------
I suggest `getSubtarget().is64Bit()` instead of `TT.getArch() == ...x86_64`, it's marginally more explicit. My first (silly) thought was "why are we checking if we're targetting x86, we are already in the x86 backend... oh right, we don't do this for 32-bit".

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123934/new/

https://reviews.llvm.org/D123934