[PATCH] D123943: MachineModuleInfo: Move AddrLabelSymbols to AsmPrinter

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:180
+  /// block's address of label.
+  MMIAddrLabelMap *AddrLabelSymbols = nullptr;
+
----------------
This can be a unique_ptr so long as the ctor and dtor are defined in the relevant cpp file.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:176-177
+
+namespace llvm {
+class MMIAddrLabelMap {
+  MCContext &Context;
----------------
nit: This can be `class llvm::MMIAddrLabelMap {`, and then the extra braces are not required.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123943/new/

https://reviews.llvm.org/D123943