[PATCH] D123897: [X86] Unbreak LIT/FileCheck

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 17 02:41:43 PDT 2022


lebedev.ri added a comment.

Thanks everyone, i do believe we now have a rough understanding/consensus.
Does anyone feel like stamping the patch?

In D123897#3455499 <https://reviews.llvm.org/D123897#3455499>, @mtrofin wrote:

> <...>

I think it may be interesting to fix FileCheck to default to `--allow-unused-prefixes`
if the first line of the test contains `NOTE: Assertions have been autogenerated by` comment,
but given that `X86/` effectively does not welcome new manually-written checklines,
i believe the `X86`-specific default change/unbreak is a correct thing to do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897



More information about the llvm-commits mailing list