[PATCH] D123901: [LLVM][Casting.h] Allow dyn_cast to return Optional for types that are not constructble from nullptr.

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Not a big fan of this overload. dyn_cast is such a core operation, I'd rather not muddy things by making it return `Optional<>` -- but only sometimes. I expect this is going to cause a lot of confusion when people work on an `Instruction &`, but really want to be working on `Instruction *`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123901/new/

https://reviews.llvm.org/D123901