[PATCH] D123897: [X86] Unbreak LIT/FileCheck

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D123897#3455488 <https://reviews.llvm.org/D123897#3455488>, @lebedev.ri wrote:

> Once again, let's cut on the bikeshedding here,  please.
> This is only affects X86 codegen tests, all of which should be autogenerated in the first place, so the check prefix can not be wrong in the first place.

My $0.02, personally I think this patch is fine, what prompted me to propose an alternative is that CodeGen/X86 has 2483 tests with 'autogenerated' out of 4136 total; so with an eye to those ~1K manual ones, got me thinking, maybe there's a way we can easily get everything we want? If that's not as easily achievable as this patch at this moment, we can punt it (i.e. let's go ahead with this patch to unblock Roman - if he's got a bunch of tests needing updating, if I were him, I'd also hate having to preen each of them; and then we can follow up with a patch that fixes the autogen-ers and removes this lit.local.cfg)

How's this sound?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897