[PATCH] D123897: [X86] Unbreak LIT/FileCheck

Sat Apr 16 10:45:49 PDT 2022

MaskRay added a comment.

In D123897#3455437 <https://reviews.llvm.org/D123897#3455437>, @lebedev.ri wrote:

> In D123897#3455435 <https://reviews.llvm.org/D123897#3455435>, @mtrofin wrote:
>
>> In D123897#3455433 <https://reviews.llvm.org/D123897#3455433>, @lebedev.ri wrote:
>>
>>> In D123897#3455425 <https://reviews.llvm.org/D123897#3455425>, @mtrofin wrote:
>>>
>>>> Added David back - he had some concerns and a good (I think) suggestion. Could this patch do his “UTC_ARGS: —allow-unused-prefixes” suggestion instead? Seems it wouldn't be any bigger of a change, and I think everybody would have their concerns addressed.
>>>
>>> Everybody except me? :)
>>
>> My understanding is that his proposal will make any test generated with one of the auto-generators automatically enrolled into --allow-unused-prefixes. Wouldn't that address your scenario?
>
>
>
> 1. It's a workaround for the case of unchanged default. I'm interested in fixing the default, not workarounding it.

If you want to flip the default again, you can start a new thread on discourse and leave a comment on https://discourse.llvm.org/t/rfc-filecheck-dis-allowing-unused-prefixes/56806
Note that the first message in the thread mentioned "1579 tests have this property." that was a significant portion of the testsuite.
I object to the flip (to true) since it will leave llvm-project's testsuite into the historical state that check prefixes easily got wrong.

You probably need to re-frame the problem you observed in more words.

> 2. `UTC_ARGS` controls the default arguments for the `update_llc_test_checks.py` family of checks. Can you please explain how it would happen to affect the FileCheck? Should `update_llc_test_checks.py` rewrite the RUN lines? Or would FileCheck itself  need to be modified to somehow look for it?

I agree `UTC_ARGS` is currently only recognized by `update*test_checks.py`. FileCheck doesn't support it. If there is indeed a significant need, I think we can teach FileCheck a similar marker (if this is considered better than changing all FileCheck lines in the file to specify --allow-unused-prefixes)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897