[PATCH] D123897: [X86] Unbreak LIT/FileCheck

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 16 09:42:41 PDT 2022


MaskRay added a comment.

You need evidence to back up your statement. How is writing new `llvm/test/CodeGen/X86` tests impossible now? Are there concrete examples when `--allow-unused-prefixes=false` makes the test less appealing in a way which can't be mitigated?
I think some folks may be interested to improve `update_llc_test_checks.py` to mitigate the effect while retaining the error checking effect. There may also be users who want the new effect even with `update_llc_test_checks.py` generated tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897



More information about the llvm-commits mailing list