[PATCH] D123846: [RS4GC] Prune inputs of BDV if they are BDV themselves

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:937
       auto canPruneInput = [&](Value *V) {
-        Value *BDV = findBaseOrBDV(V, Cache);
-        if (V->stripPointerCasts() != BDV)
+        // BDV is present in the states map, so in case when the input is the
+        // BDV itself, we'd return false. So explicitly check this case.
----------------
Please rephrase this comment to emphasize this is handling the phi case (as no other instruction can have itself as operand in reachable code).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123846/new/

https://reviews.llvm.org/D123846