[PATCH] D123897: [X86] Unbreak LIT/FileCheck

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added a comment.

In D123897#3455358 <https://reviews.llvm.org/D123897#3455358>, @xbolva00 wrote:

> If a new test needs, it can specify ‘ --allow-unused-prefixes’ explicitly, no? If we apply patch like this one to more and more folders, than original work was a wasted effort.

In these cases - where whole directories are predominantly auto-generated tests - the idea was to use the approach in this patch, for example Transforms/Attributor/lit.local.cfg (where basically all are autogenerated). For CodeGen/X86, more than half of the tests have the word 'autogenerated' in them.

Maybe we should just use the word `autogenerated` in the header of the .ll file and make FileCheck automatically switch to --allow-unused-prefixes in that case?

>>> D95849 <https://reviews.llvm.org/D95849> was a tragedy/sabotage that should have never happened
>
> Too strong words I would say. Read code of conduct. You can disagree - give exact facts instead of calling someone’s (in this case @MaskRay) work a project sabotage. Plus, I see no objections from you in linked phab review and in rfc thread (and year passed…).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123897/new/

https://reviews.llvm.org/D123897