[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:513
+    return MachineOptimizationRemarkAnalysis(
+               "kernel-resource-usage", "KernelName",
+               MF.getFunction().getSubprogram(), &MF.front())
----------------
Define the string name somewhere to avoid repeating it everywhere


================
Comment at: llvm/lib/Target/AMDGPU/SIProgramInfo.h:52
     uint32_t NumSGPR = 0;
+    unsigned LDSSpillSize = 0;
+    unsigned SGPRSpill = 0;
----------------
This isn't a spill size


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123878/new/

https://reviews.llvm.org/D123878