[PATCH] D123872: Force GHashCell to be 8-byte-aligned.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.

lgtm

In D123872#3454636 <https://reviews.llvm.org/D123872#3454636>, @jyknight wrote:

> Sidenote: Oh, yikes! I didn't even notice before that this code is doing reinterpret_cast from a `GHashCell*` to a `std::atomic<GHashCell>*`. That's...kinda not great...

Yeah, I think I was excited with the performance results, and shipped some prototype code. The idea is that we only need to do atomic operations during hash table insertion. Afterwards, the table is used as readonly data. I wouldn't be surprised if there are issues lurking here for ISAs with weak memory models.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123872/new/

https://reviews.llvm.org/D123872