[PATCH] D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:1808
 CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare)
+CHECK_SIMPLE_CLAUSE(CancelConstruct, OMPC_cancel_construct)
 
----------------
raghavendhra wrote:
> kiranchandramohan wrote:
> > On a first look, it looks like we have a construct here instead of a clause. Would `CancelConstructType` be a better name? 
> If I change CancelConstruct to CancelConstructType, I am getting
> 
> llvm-project/flang/lib/Semantics/check-omp-structure.cpp:1808:21: error: ‘CancelConstructType’ in ‘struct Fortran::parser::OmpClause’ does not name a type
>  1808 | CHECK_SIMPLE_CLAUSE(CancelConstructType, OMPC_cancel_construct)
> 
> Also, it looks like code in flang has been using CancelConstruct in multiple places.
You have the error because you have to update the name in OMP.td first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123828/new/

https://reviews.llvm.org/D123828