[PATCH] D123702: [NVPTX] Disable parens for identifiers starting with '$'
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 15 11:25:03 PDT 2022
tra added inline comments.
================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:2256
+ << "offset: " << F.getOffset() << ", value: ";
+ F.getValue()->print(OS, MAI);
+ OS << ", kind: " << Info.Name << "\n";
----------------
This is awkward.
Perhaps we should consider adding some sort of `withMAI(F.getValue(), MAI)` -> std::pair<MCExpr*, MCAsmInfo*> wrapper and an overloaded `operator<<` to catch it and pass MAI along to MCExpr::print().
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123702/new/
https://reviews.llvm.org/D123702
More information about the llvm-commits
mailing list